Page MenuHomePhabricator

Implement a dedicated "diffusion.blame" API method
ClosedPublic

Authored by epriestley on Jan 6 2016, 1:17 PM.
Tags
None
Referenced Files
F21083184: D14957.diff
Wed, Jul 1, 9:58 AM
Unknown Object (File)
Fri, Jun 19, 4:06 PM
Unknown Object (File)
Fri, Jun 19, 4:06 PM
Unknown Object (File)
Fri, Jun 19, 4:06 PM
Unknown Object (File)
Sat, Jun 13, 2:30 AM
Unknown Object (File)
Sat, Jun 13, 2:29 AM
Unknown Object (File)
Sat, Jun 13, 2:23 AM
Unknown Object (File)
May 31 2026, 10:34 PM
Subscribers
None

Details

Summary

Fixes T2451. Several motivations here, from strongest to weakest:

  • Currently, getting blame and file content are closely entwined. This makes fixing T9319 more difficult, and I want to fix it. I want to separate blame from content so there's more flexibility in how we approach this issue.
  • This makes pursuing T2450 easier, if it turns out to be a meaningful win.
  • If we can get a win on blame performance, we can do arc blame eventually if we want.
Test Plan
  • Blamed in SVN, Git and Mercurial.

Diff Detail

Repository
rP Phabricator
Branch
blame1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9961
Build 12031: Run Core Tests
Build 12030: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Implement a dedicated "diffusion.blame" API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.