Page MenuHomePhabricator
Differential D14955

Make unsubscribing from a project have an effect
ClosedPublic
Actions

Authored by epriestley on Jan 6 2016, 2:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 12:20 AM
Unknown Object (File)
Fri, Jan 31, 1:53 PM
Unknown Object (File)
Fri, Jan 31, 2:11 AM
Unknown Object (File)
Thu, Jan 30, 4:12 AM
Unknown Object (File)
Mon, Jan 27, 6:15 AM
Unknown Object (File)
Fri, Jan 24, 10:58 AM
Unknown Object (File)
Jan 21 2025, 10:31 AM
Unknown Object (File)
Dec 10 2024, 10:28 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10089: Unsubscribing from a Project seems to have no effect
Commits
Restricted Diffusion Commit
rPd326c6096e6e: Make unsubscribing from a project have an effect
Summary

Fixes T10089. This did work at one point, but was broken by D12868, which got too aggressive about mailing members.

We don't want to send mail to all members by default, only those who are subscribed. The parent implementation of getMailCC() handles this for us.

Test Plan

Joined a project as users A and B. Unsubscribed with B. Made an edit.

Before patch: both A and B got mail. After patch: only A got mail.

Diff Detail

Repository
rP Phabricator
Branch
unsub1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9958
Build 12025: Run Core Tests
Build 12024: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36133.Jan 6 2016, 2:10 AM
epriestley retitled this revision from to Make unsubscribing from a project have an effect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10089: Unsubscribing from a Project seems to have no effect.
chad accepted this revision.Jan 6 2016, 2:14 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 2:14 AM
Closed by commit rPd326c6096e6e: Make unsubscribing from a project have an effect (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2016, 2:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
editor/
9 lines

Diff 36133

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
Phabricator · Built by Phacility