Differential D14906

Fix an excessively aggressive transaction check in Owners
ClosedPublic
Actions

Authored by epriestley on Dec 28 2015, 9:30 PM.

Details

Reviewers

chad

Maniphest Tasks

T10058: Cannot Archive Owners Package

Commits

Restricted Diffusion Commit
rP1443e4b13dd4: Fix an excessively aggressive transaction check in Owners

Summary

Fixes T10058. We don't need to continue on this check if no path changes are being applied.

Test Plan

Archived an owners package.

Diff Detail

Repository

rP Phabricator

Branch

owners1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9849
Build 11862: Run Core Tests
Build 11861: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36026.Dec 28 2015, 9:30 PM

epriestley retitled this revision from to Fix an excessively aggressive transaction check in Owners.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10058: Cannot Archive Owners Package.

chad accepted this revision.Dec 28 2015, 9:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 28 2015, 9:42 PM

Closed by commit rP1443e4b13dd4: Fix an excessively aggressive transaction check in Owners (authored by epriestley, committed by epriestley). · Explain WhyDec 28 2015, 10:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

editor/

PhabricatorOwnersPackageTransactionEditor.php

4 lines

Diff 36026

View Options

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

Fix an excessively aggressive transaction check in OwnersClosedPublicActions