Page MenuHomePhabricator
Differential D14886

Improve UX and messaging for certain errors when landing revisions
ClosedPublic
Actions

Authored by epriestley on Dec 26 2015, 8:35 PM.
Tags
None
Referenced Files
F15585334: D14886.id35982.diff
Thu, May 8, 8:08 AM
F15581606: D14886.id35994.diff
Wed, May 7, 12:00 PM
F15578478: D14886.diff
Tue, May 6, 7:16 PM
F15563527: D14886.id35994.diff
Wed, Apr 30, 9:20 AM
F15558229: D14886.id35994.diff
Tue, Apr 29, 1:41 AM
F15548820: D14886.id35982.diff
Sun, Apr 27, 2:20 AM
F15546905: D14886.id.diff
Sat, Apr 26, 5:24 PM
F15541287: D14886.diff
Fri, Apr 25, 11:23 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9994: Merge conflicts causes resources not being able to be released
Commits
Restricted Diffusion Commit
rP367955f3fd9c: Improve UX and messaging for certain errors when landing revisions
Summary

Ref T9994.

  • Allow errors to be dismissed.
  • Tailor messaging for closed/abandoned revisions.
  • Reduce scare messaging on land dialog, since it's not really that scary anymore.
Test Plan
  • Dismissed errors.
  • Hit new warnings.
  • Wasn't as scared when landing.

Diff Detail

Repository
rP Phabricator
Branch
land1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9805
Build 11793: Run Core Tests
Build 11792: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35982.Dec 26 2015, 8:35 PM
epriestley retitled this revision from to Improve UX and messaging for certain errors when landing revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9994: Merge conflicts causes resources not being able to be released.
epriestley mentioned this in T9994: Merge conflicts causes resources not being able to be released.Dec 26 2015, 8:40 PM
chad accepted this revision.Dec 27 2015, 2:38 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 27 2015, 2:38 PM
Closed by commit rP367955f3fd9c: Improve UX and messaging for certain errors when landing revisions (authored by epriestley, committed by epriestley). · Explain WhyDec 27 2015, 4:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35982

View Options

resources/sql/autopatches/20151226.reop.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionOperationController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Loading...
View Options

src/applications/drydock/controller/DrydockRepositoryOperationDismissController.php

Loading...
View Options

src/applications/drydock/operation/DrydockLandRepositoryOperation.php

Loading...
View Options

src/applications/drydock/query/DrydockRepositoryOperationQuery.php

Loading...
View Options

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...
View Options

src/applications/drydock/view/DrydockRepositoryOperationStatusView.php

Loading...
Phabricator · Built by Phacility