Paths

Table of Contentst

Differential D14881

Fix hovercard behavior for multiple copies of the same object
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 8:39 PM.

Details

Reviewers

chad

Maniphest Tasks

T8980: Make hovecards activate for standard handle lists

Commits

Restricted Diffusion Commit
rPe0ad791247f6: Fix hovercard behavior for multiple copies of the same object

Summary

Ref T8980. Previously, if you had like T123 T123 T123 and waved your mouse over them, we wouldn't move the card. Now, move the card.

Test Plan

Waved mouse. Saw the card move.

Diff Detail

Repository

rP Phabricator

Branch

hover5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9790
Build 11771: Run Core Tests
Build 11770: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35971.Dec 24 2015, 8:39 PM

epriestley retitled this revision from to Fix hovercard behavior for multiple copies of the same object.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8980: Make hovecards activate for standard handle lists.

This mostly happened with stuff like:

Author: dog
Subscribers: dog

So you'd mouse over "Author", then move to "Subscribers" but the card wouldn't move.

BONUS! More hovercards!

chad accepted this revision.Dec 24 2015, 9:16 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 24 2015, 9:16 PM

Closed by commit rPe0ad791247f6: Fix hovercard behavior for multiple copies of the same object (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 9:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

20 lines

webroot/

rsrc/

js/

core/

Hovercard.js

5 lines

Diff 35971

View Options

resources/celerity/map.php