Differential D14876

Modernize Differential SearchEngine just enough to get NUX
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 6:33 PM.

Details

Reviewers

chad

Maniphest Tasks

T10032: Improve individual NUX states (application level)

Commits

Restricted Diffusion Commit
rP992dedcadd20: Modernize Differential SearchEngine just enough to get NUX

Summary

Ref T10032. This is sufficent to hit NUX without doing anything bad.

Test Plan

Visited NUX.
Browsed normally.

Screen Shot 2015-12-24 at 10.32.01 AM.png (1×1 px, 154 KB)

Diff Detail

Repository

rP Phabricator

Branch

dquery1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9779
Build 11754: Run Core Tests
Build 11753: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35960.Dec 24 2015, 6:33 PM

epriestley retitled this revision from to Modernize Differential SearchEngine just enough to get NUX.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10032: Improve individual NUX states (application level).

chad accepted this revision.Dec 24 2015, 6:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 24 2015, 6:38 PM

crazy

Closed by commit rP992dedcadd20: Modernize Differential SearchEngine just enough to get NUX (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

7 lines

Diff 35960

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Modernize Differential SearchEngine just enough to get NUXClosedPublicActions