Page MenuHomePhabricator

Fix project hashtag bugs: allow simultaneously changing name and adding same name as a tag
ClosedPublic

Authored by epriestley on Dec 24 2015, 12:35 PM.
Tags
None
Referenced Files
F14057213: D14871.diff
Sun, Nov 17, 1:25 AM
F13957609: D14871.id35947.diff
Oct 14 2024, 10:16 AM
Unknown Object (File)
Sep 30 2024, 10:21 AM
Unknown Object (File)
Sep 30 2024, 10:20 AM
Unknown Object (File)
Sep 30 2024, 4:56 AM
Unknown Object (File)
Sep 30 2024, 4:18 AM
Unknown Object (File)
Sep 30 2024, 4:15 AM
Unknown Object (File)
Sep 26 2024, 11:46 PM
Subscribers
None

Details

Summary

Fixes T8509. Changes these behaviors:

  • If you create a project named "QQQ" and add "qqq" as a hashtag at the same time, it fails in an unhelpful way. (Now: succeeds.)
  • If you add "qqq" as a hashtag to a project with primary hashtag "qqq", it fails in a correct but probably unnecessary way (Now: just works).

We could make one or both of these behaviors show the user an error instead, but I think it's likely that this behavior is just what they always want.

Test Plan
  • Added failing tests and made them pass.
  • Executed both scenarios described above from the web UI.

Diff Detail

Repository
rP Phabricator
Branch
slug2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9766
Build 11735: Run Core Tests
Build 11734: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix project hashtag bugs: allow simultaneously changing name and adding same name as a tag.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:50 PM
This revision was automatically updated to reflect the committed changes.