Page MenuHomePhabricator

Fix project hashtag bugs: allow simultaneously changing name and adding same name as a tag
ClosedPublic

Authored by epriestley on Dec 24 2015, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 3:17 AM
Unknown Object (File)
Thu, Dec 5, 11:52 PM
Unknown Object (File)
Wed, Dec 4, 5:57 PM
Unknown Object (File)
Fri, Nov 29, 7:08 PM
Unknown Object (File)
Fri, Nov 29, 7:08 PM
Unknown Object (File)
Fri, Nov 29, 7:08 PM
Unknown Object (File)
Fri, Nov 29, 2:48 PM
Unknown Object (File)
Fri, Nov 29, 6:30 AM
Subscribers
None

Details

Summary

Fixes T8509. Changes these behaviors:

  • If you create a project named "QQQ" and add "qqq" as a hashtag at the same time, it fails in an unhelpful way. (Now: succeeds.)
  • If you add "qqq" as a hashtag to a project with primary hashtag "qqq", it fails in a correct but probably unnecessary way (Now: just works).

We could make one or both of these behaviors show the user an error instead, but I think it's likely that this behavior is just what they always want.

Test Plan
  • Added failing tests and made them pass.
  • Executed both scenarios described above from the web UI.

Diff Detail

Repository
rP Phabricator
Branch
slug2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9766
Build 11735: Run Core Tests
Build 11734: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix project hashtag bugs: allow simultaneously changing name and adding same name as a tag.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:50 PM
This revision was automatically updated to reflect the committed changes.