Page MenuHomePhabricator

Fix project hashtag bugs: duplicate tags, uppercase tags
ClosedPublic

Authored by epriestley on Dec 24 2015, 12:07 PM.
Tags
None
Referenced Files
F15504737: D14870.diff
Mon, Apr 14, 8:09 PM
F15487664: D14870.diff
Thu, Apr 10, 4:00 PM
F15416023: D14870.id35953.diff
Thu, Mar 20, 8:43 AM
F15413461: D14870.id35946.diff
Wed, Mar 19, 6:54 PM
F15408664: D14870.id.diff
Wed, Mar 19, 12:40 AM
F15402433: D14870.diff
Mon, Mar 17, 10:31 PM
F15393155: D14870.id35953.diff
Mar 15 2025, 8:06 PM
F15294657: D14870.id35946.diff
Mar 5 2025, 10:21 AM
Subscribers
None

Details

Summary

Ref T8509. This fixes three issues:

  • Adding a slug like UPPERCASE would not give you a normalized slug. (Now: normalizes as uppercase.)
  • Adding a slug like UPPERCASE would allow you to give two different projects the different tags UPPERCASE and uppercase (and UpPeRcAsE, etc). (Now: second tag is rejected as a duplicate.)
  • Adding multiple identical or similar slugs would produce a duplicate key exception. (Now: ignores the duplicates.)
Test Plan
  • Added test coverage.
  • Made tests pass.
  • Hit these cases in the UI.

Diff Detail

Repository
rP Phabricator
Branch
slug1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9765
Build 11733: Run Core Tests
Build 11732: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix project hashtag bugs: duplicate tags, uppercase tags.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:30 PM
This revision was automatically updated to reflect the committed changes.