Page MenuHomePhabricator
Differential D14852

Fix two issues with Phurl / Badges mail generation
ClosedPublic
Actions

Authored by epriestley on Dec 22 2015, 4:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 3:10 PM
Unknown Object (File)
Tue, Dec 17, 9:00 AM
Unknown Object (File)
Sat, Dec 14, 4:51 PM
Unknown Object (File)
Thu, Dec 12, 8:40 AM
Unknown Object (File)
Wed, Dec 11, 8:35 PM
Unknown Object (File)
Wed, Dec 11, 4:35 AM
Unknown Object (File)
Wed, Dec 4, 6:48 AM
Unknown Object (File)
Fri, Nov 29, 11:11 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP61a92df66e20: Fix two issues with Phurl / Badges mail generation
Summary
  • Phurl is missing a ReplyHandler / MailReceiver (all of this code should get cleaned up eventually, but I don't plan to get to it for a while).
  • Badges has a bad call.

This should clean up some bad daemon tasks.

Test Plan

Saw fewer daemon errors after these changes.

Diff Detail

Repository
rP Phabricator
Branch
mail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9723
Build 11668: Run Core Tests
Build 11667: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35904.Dec 22 2015, 4:10 PM
epriestley retitled this revision from to Fix two issues with Phurl / Badges mail generation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Dec 22 2015, 4:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 4:18 PM
Closed by commit rP61a92df66e20: Fix two issues with Phurl / Badges mail generation (authored by epriestley, committed by epriestley). · Explain WhyDec 22 2015, 4:19 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Dec 22 2015, 4:27 PM

Works great!

Revision Contents
Changeset List

Diff 35904

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php

Loading...
View Options

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php

Loading...
View Options

src/applications/phurl/mail/PhabricatorPhurlURLMailReceiver.php

Loading...
View Options

src/applications/phurl/mail/PhabricatorPhurlURLReplyHandler.php

Loading...
Phabricator · Built by Phacility