Don't select {F...} text after adding it to textareas
ClosedPublic
Actions

Authored by epriestley on Dec 22 2015, 3:51 PM.

Details

Reviewers

chad

Maniphest Tasks

T10039: Uploading file whilst typing causes file to be lost

Commits

Restricted Diffusion Commit
rPaf8cc2a5fc75: Don't select {F...} text after adding it to textareas

Summary

Fixes T10039. We add text to textareas in two cases:

Users clicking assitance buttons in Remarkup text areas.
Drag-and-drop file uploads.

In case (1), it makes sense to highlight the text (it shows the user what we inserted, and lets them undo the action easily if it isn't what they wanted).

In case (2), it does not. Users almost never want to delete or edit a file reference. It is slightly nice to have the reference as a visual callout, but I don't think this is a big deal.

Change the behavior so that we highlight only for remarkup buttons, not for drag-and-drop files.

Test Plan

Clicked an "isnert quote" button on remarkup assist area, got highlighted example text.
Dragged and dropped a file, got text inserted with no highlight.

Diff Detail

Repository

rP Phabricator

Branch

upload1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9720
Build 11663: Run Core Tests
Build 11662: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35901.Dec 22 2015, 3:51 PM

epriestley retitled this revision from to Don't select {F...} text after adding it to textareas.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10039: Uploading file whilst typing causes file to be lost.

There's a small behavioral change here: uploading multiple files no longer puts newlines between them. That seems OKish? Maybe we should insert {F...}\n?

Actually, let me just put that old behavior back for now, since it's probably a little better than {F...}{F...}.