Page MenuHomePhabricator
Differential D14847

More NUX states
ClosedPublic
Actions

Authored by chad on Dec 21 2015, 9:11 PM.
Tags
None
Referenced Files
F15343448: D14847.diff
Mar 9 2025, 11:01 PM
F15332908: D14847.diff
Mar 7 2025, 9:55 PM
F15324220: D14847.id35883.diff
Mar 7 2025, 1:19 AM
Unknown Object (File)
Feb 14 2025, 1:31 PM
Unknown Object (File)
Feb 9 2025, 2:36 PM
Unknown Object (File)
Feb 9 2025, 12:14 AM
Unknown Object (File)
Feb 9 2025, 12:14 AM
Unknown Object (File)
Feb 9 2025, 12:14 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10032: Improve individual NUX states (application level)
Commits
Restricted Diffusion Commit
rP5fecd55d6edd: More NUX states
Summary

Ref T10032, adds "Basic" NUX to more applications.

Test Plan

Visit each with ?nux=true and click on the create link. T10032 is tracking which apps need general modernization to pick up these changes.

Diff Detail

Repository
rP Phabricator
Branch
nux-5 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9701
Build 11639: Run Core Tests
Build 11638: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35882.Dec 21 2015, 9:11 PM
chad retitled this revision from to More NUX states.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10032: Improve individual NUX states (application level).
Herald added a subscriber: Korvin. · View Herald TranscriptDec 21 2015, 9:11 PM
epriestley accepted this revision.Dec 21 2015, 9:12 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/differential/query/DifferentialRevisionSearchEngine.php
350

Maybe "revisions" instead of "diffs".

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php
127–128

double spaces

This revision is now accepted and ready to land.Dec 21 2015, 9:12 PM
Closed by commit rP5fecd55d6edd: More NUX states (authored by chad, committed by chad). · Explain WhyDec 21 2015, 9:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
query/
12 lines
differential/
query/
20 lines
files/
query/
19 lines
legalpad/
query/
20 lines
owners/
query/
21 lines
passphrase/
query/
20 lines
spaces/
query/
20 lines

Diff 35882

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

Loading...
View Options

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

Loading...
View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php

Loading...
Phabricator · Built by Phacility