Page MenuHomePhabricator
Differential D14827

Add a Read More link to PHUIDocumentSummaryView
ClosedPublic
Actions

Authored by chad on Dec 19 2015, 8:02 PM.
Tags
None
Referenced Files
F15435929: D14827.id.diff
Tue, Mar 25, 11:01 AM
F15435928: D14827.id35852.diff
Tue, Mar 25, 11:01 AM
F15434850: D14827.id.diff
Tue, Mar 25, 5:42 AM
F15433573: D14827.id35850.diff
Mon, Mar 24, 11:47 PM
F15429885: D14827.diff
Mon, Mar 24, 4:44 AM
F15412356: D14827.id35850.diff
Wed, Mar 19, 12:38 PM
F15396656: D14827.id35852.diff
Sun, Mar 16, 3:39 PM
F15345807: D14827.id35848.diff
Mon, Mar 10, 12:34 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP9d1ba9c03808: Add a Read More link to PHUIDocumentSummaryView
Summary

Currently it's difficult to notice posts may be much longer than the summary (in most cases, actually), Adds a consistent "Read More" link to the full post. Also made sure "violet" was more consistantly used.

Test Plan

Review summaries in Phame

pasted_file (855×861 px, 175 KB)

Diff Detail

Repository
rP Phabricator
Branch
phame-read-more (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9669
Build 11585: Run Core Tests
Build 11584: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35848.Dec 19 2015, 8:02 PM
chad retitled this revision from to Add a Read More link to PHUIDocumentSummaryView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 19 2015, 8:02 PM
chad edited the test plan for this revision. (Show Details)Dec 19 2015, 8:05 PM
chad updated this revision to Diff 35850.Dec 19 2015, 8:29 PM
  • Clean up bottom spacing
epriestley accepted this revision.Dec 19 2015, 8:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2015, 8:45 PM
Closed by commit rP9d1ba9c03808: Add a Read More link to PHUIDocumentSummaryView (authored by chad, committed by chad). · Explain WhyDec 19 2015, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
view/
phui/
10 lines
webroot/
rsrc/
css/
application/
phame/
6 lines
phui/
19 lines

Diff 35850

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIDocumentSummaryView.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document-summary.css

Loading...
Phabricator · Built by Phacility