Page MenuHomePhabricator

Allow custom fields to be ordered ascending or descending
ClosedPublic

Authored by epriestley on Dec 16 2015, 8:20 PM.
Tags
None
Referenced Files
F14387489: D14800.id35786.diff
Sat, Dec 21, 2:47 PM
Unknown Object (File)
Mon, Dec 16, 5:07 PM
Unknown Object (File)
Wed, Dec 11, 7:02 AM
Unknown Object (File)
Sun, Dec 8, 12:26 AM
Unknown Object (File)
Sat, Dec 7, 1:27 PM
Unknown Object (File)
Fri, Dec 6, 9:43 AM
Unknown Object (File)
Sun, Dec 1, 12:14 PM
Unknown Object (File)
Sun, Dec 1, 12:14 PM
Subscribers
None

Details

Summary

Fixes T6864. This creates a sort of busy menu but I think that's proably fine -- users are opting into activating these fields for search anyway.

In the future, we could refine this as, e.g.:

  • don't show these options in the dropdown;
  • do show them on some new "http prefilling" sort of page;
  • then you access them as an advanced user with ?order=secret-magic.

But I'm not going to bother for now.

Test Plan

Ordered by an int field, then reversed the order.

Diff Detail

Repository
rP Phabricator
Branch
sort1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9603
Build 11489: Run Core Tests
Build 11488: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow custom fields to be ordered ascending or descending.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.