Page MenuHomePhabricator

Remove all references to the Conduit ConnectionLog
ClosedPublic

Authored by epriestley on Dec 14 2015, 8:52 PM.
Tags
None
Referenced Files
F15341402: D14780.id35741.diff
Sun, Mar 9, 8:06 PM
F15334905: D14780.diff
Sat, Mar 8, 1:12 PM
Unknown Object (File)
Sun, Mar 2, 9:19 AM
Unknown Object (File)
Wed, Feb 19, 5:34 AM
Unknown Object (File)
Mon, Feb 10, 1:59 AM
Unknown Object (File)
Feb 9 2025, 12:08 AM
Unknown Object (File)
Jan 31 2025, 9:34 PM
Unknown Object (File)
Jan 26 2025, 5:58 AM
Subscribers
None

Details

Summary

Ref T5955, T9980, T9982.

We currently store two types of Conduit logs: connection logs and method logs.

Originally, Conduit worked like web logins: you'd call conduit.connect and then get a session back. This approach still works, but new clients don't use it and it will probably stop working eventually after T5955 is further along.

There was no real reason for things to work like this and no other API in the world does, I think it was just slightly easier to implement back in 2011.

This table was used to group up related calls in a UI long ago, I think, but that got deleted at some point. In any case, it serves no purpose in modern Phabricator.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
clog3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9559
Build 11423: Run Core Tests
Build 11422: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2015, 8:55 PM
This revision was automatically updated to reflect the committed changes.