Page MenuHomePhabricator
Differential D14776

Formalize custom Conduit fields on objects
ClosedPublic
Actions

Authored by epriestley on Dec 14 2015, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 19, 5:33 AM
Unknown Object (File)
Wed, Feb 19, 5:33 AM
Unknown Object (File)
Wed, Feb 19, 5:33 AM
Unknown Object (File)
Sun, Feb 9, 12:08 AM
Unknown Object (File)
Sun, Feb 9, 12:08 AM
Unknown Object (File)
Sun, Feb 9, 12:08 AM
Unknown Object (File)
Fri, Feb 7, 10:34 AM
Unknown Object (File)
Fri, Jan 31, 4:12 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9964: Fill in Conduit support infrastructure for ApplicationEditor changes
Commits
Restricted Diffusion Commit
rP0a50219f1b4f: Formalize custom Conduit fields on objects
Summary

Ref T9964. This just adds more structure to application fields, to make it harder to make typos and easier to validate them later.

Test Plan

Viewed APIs, called some APIs, saw good documentation and correct results.

Diff Detail

Repository
rP Phabricator
Branch
attach5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php:73XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9549
Build 11409: Run Core Tests
Build 11408: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35731.Dec 14 2015, 2:45 PM
epriestley retitled this revision from to Formalize custom Conduit fields on objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
chad accepted this revision.Dec 14 2015, 4:28 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2015, 4:28 PM
Closed by commit rP0a50219f1b4f: Formalize custom Conduit fields on objects (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
conduit/
interface/
8 lines
37 lines
maniphest/
storage/
48 lines
owners/
storage/
32 lines
paste/
storage/
32 lines
policy/
engineextension/
9 lines
search/
engine/
19 lines
4 lines
engineextension/
20 lines
spaces/
engineextension/
10 lines
infrastructure/
customfield/
engineextension/
10 lines

Diff 35731

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conduit/interface/PhabricatorConduitResultInterface.php

Loading...
View Options

src/applications/conduit/interface/PhabricatorConduitSearchFieldSpecification.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/paste/storage/PhabricatorPaste.php

Loading...
View Options

src/applications/policy/engineextension/PhabricatorPolicySearchEngineExtension.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorLiskSearchEngineExtension.php

Loading...
View Options

src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php

Loading...
Phabricator · Built by Phacility