Page MenuHomePhabricator
Differential D14765

Flesh out Conduit types for Paste search fields
ClosedPublic
Actions

Authored by epriestley on Dec 13 2015, 3:03 PM.
Tags
None
Referenced Files
F14352860: D14765.diff
Thu, Dec 19, 3:01 PM
Unknown Object (File)
Mon, Dec 16, 4:41 PM
Unknown Object (File)
Wed, Dec 11, 10:56 PM
Unknown Object (File)
Wed, Dec 11, 1:18 PM
Unknown Object (File)
Wed, Dec 11, 7:24 AM
Unknown Object (File)
Sat, Dec 7, 1:36 AM
Unknown Object (File)
Tue, Dec 3, 2:13 PM
Unknown Object (File)
Sun, Dec 1, 12:09 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9964: Fill in Conduit support infrastructure for ApplicationEditor changes
Commits
Restricted Diffusion Commit
rP0282ce74ab8c: Flesh out Conduit types for Paste search fields
Summary

Ref T9964. This fills in types and descriptions for ApplicationSearch fields in Paste.

Test Plan

Got this nice table now:

Screen Shot 2015-12-13 at 7.01.18 AM.png (348×669 px, 83 KB)

Diff Detail

Repository
rP Phabricator
Branch
nx7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/search/field/PhabricatorSearchSubscribersField.php:22XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9516
Build 11353: Run Core Tests
Build 11352: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35698.Dec 13 2015, 3:03 PM
epriestley retitled this revision from to Flesh out Conduit types for Paste search fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
chad edited edge metadata.Dec 13 2015, 4:06 PM

there's a failed build here? related?

chad accepted this revision.Dec 13 2015, 4:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 4:09 PM
epriestley added a comment.Dec 13 2015, 4:47 PM

Ah, yeah, that's legit.

epriestley updated this revision to Diff 35702.Dec 13 2015, 4:48 PM
epriestley edited edge metadata.
  • Fix user/viewer call.
chad added a comment.Dec 13 2015, 4:50 PM

A few of this diffs had that failure.

epriestley added a comment.Dec 13 2015, 4:50 PM

Yeah, this fix should fix the other ones.

Closed by commit rP0282ce74ab8c: Flesh out Conduit types for Paste search fields (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2015, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35698

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitEpochParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitListParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitPHIDListParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitProjectListParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitStringListParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitUserListParameterType.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php

Loading...
View Options

src/applications/project/searchfield/PhabricatorProjectSearchField.php

Loading...
View Options

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchDateField.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchField.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchSubscribersField.php

Loading...
View Options

src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php

Loading...
View Options

src/applications/spaces/searchfield/PhabricatorSpacesSearchField.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php

Loading...
Phabricator · Built by Phacility