Page MenuHomePhabricator

Give ConduitAPIMethod->getMethodDescription() access to a real Viewer
ClosedPublic

Authored by epriestley on Dec 13 2015, 10:47 AM.
Tags
None
Referenced Files
F14355610: D14761.diff
Thu, Dec 19, 5:53 PM
Unknown Object (File)
Thu, Dec 5, 10:46 AM
Unknown Object (File)
Sun, Dec 1, 12:08 PM
Unknown Object (File)
Sun, Dec 1, 12:08 PM
Unknown Object (File)
Sun, Dec 1, 12:08 PM
Unknown Object (File)
Sun, Dec 1, 12:08 PM
Unknown Object (File)
Sun, Dec 1, 12:08 PM
Unknown Object (File)
Sun, Dec 1, 1:37 AM
Subscribers
None

Details

Summary

Ref T9964. The new *.search and *.edit methods generate documentation which depends on the viewer.

For example, the *.search methods show a reference table of the keys for all your saved queries.

Give them a real viewer to work with.

During normal execution, just populate this viewer with the request's viewer, so $request->getViewer() and $this->getViewer() both work and mean the same thing.

Test Plan

Screen Shot 2015-12-13 at 2.44.37 AM.png (229×539 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Branch
nx4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9512
Build 11345: Run Core Tests
Build 11344: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give ConduitAPIMethod->getMethodDescription() access to a real Viewer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 3:23 PM
epriestley edited edge metadata.
  • Clean tests.
This revision was automatically updated to reflect the committed changes.