Differential D14748

Fix double feed stories in Phame
ClosedPublic
Actions

Authored by epriestley on Dec 12 2015, 2:49 AM.

Details

Reviewers

chad

Maniphest Tasks

T9360: Unbeta Phame

Commits

Restricted Diffusion Commit
rP3d14b76f4dbe: Fix double feed stories in Phame

Summary

Ref T9360. Fixes the double-rendering of post bodies in feed stories.

Downside is that 'publish' (on its own) no longer shows a body, but that seems fine.

Test Plan

Got some double bodies.
Applied patch.
No more double bodies.

Diff Detail

Repository

rP Phabricator

Branch

phame3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9489
Build 11314: Run Core Tests
Build 11313: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35669.Dec 12 2015, 2:49 AM

epriestley retitled this revision from to Fix double feed stories in Phame.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9360: Unbeta Phame.

epriestley mentioned this in T9897: Unbeta Feedback on Phame.Dec 12 2015, 2:52 AM

chad accepted this revision.Dec 12 2015, 3:34 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 12 2015, 3:34 AM

Closed by commit rP3d14b76f4dbe: Fix double feed stories in Phame (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2015, 4:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

storage/

PhamePostTransaction.php

18 lines

Diff 35669

View Options

src/applications/phame/storage/PhamePostTransaction.php

Fix double feed stories in PhameClosedPublicActions