Fixes T9966. In this unusual, difficult-to-reach case, we throw Exception (which has no censoring) instead of CommandException (which has censoring). Throw CommandException instead.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T9966: Diffusion credentials may be leaked under some circumstances
- Commits
- Restricted Diffusion Commit
rP7b997359466f: Throw CommandException instead of Exception after `git fetch` failure in…
- Hacked up a bunch of stuff in order to hit this: disabled origin validation, origin correction, and pointed repository at a bad domain.
- Verified message is now censored correctly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- xcensor1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 9480 Build 11300: Run Core Tests Build 11299: arc lint + arc unit