Mark external -> external redirects in Phame to canonicalize URIs as "external"
ClosedPublic
Actions

Authored by epriestley on Dec 11 2015, 4:30 PM.

Details

Reviewers

chad

Maniphest Tasks

T9897: Unbeta Feedback on Phame

Commits

Restricted Diffusion Commit
rP20d2652d03c4: Mark external -> external redirects in Phame to canonicalize URIs as "external"

Summary

Ref T9897. If you visit /post/123/spoderman/ it will try to redirect you to /post/123/spiderman/, but currently only internal views work because these redirects aren't marked as safe/external.

Test Plan

Visited a misspelled/out-of-date URI on an external blog view, got a good redirect.

Diff Detail

Repository

rP Phabricator

Branch

phame2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9473
Build 11289: Run Core Tests
Build 11288: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35653.Dec 11 2015, 4:30 PM

epriestley retitled this revision from to Mark external -> external redirects in Phame to canonicalize URIs as "external".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9897: Unbeta Feedback on Phame.

chad accepted this revision.Dec 11 2015, 4:34 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 11 2015, 4:34 PM

Closed by commit rP20d2652d03c4: Mark external -> external redirects in Phame to canonicalize URIs as "external" (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2015, 4:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

PhameLiveController.php

9 lines

Diff 35653

View Options

src/applications/phame/controller/PhameLiveController.php

Mark external -> external redirects in Phame to canonicalize URIs as "external"ClosedPublicActions