Page MenuHomePhabricator
Differential D14732

Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and refs
ClosedPublic
Actions

Authored by epriestley on Dec 10 2015, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 6:54 AM
Unknown Object (File)
Fri, Jan 24, 10:24 AM
Unknown Object (File)
Fri, Jan 24, 10:24 AM
Unknown Object (File)
Fri, Jan 24, 10:24 AM
Unknown Object (File)
Fri, Jan 17, 5:00 PM
Unknown Object (File)
Dec 12 2024, 5:57 AM
Unknown Object (File)
Dec 11 2024, 7:45 AM
Unknown Object (File)
Dec 2 2024, 8:53 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9952: Let "Land Revision" target branches other than master
Commits
Restricted Diffusion Commit
rP8dcdc7534d9c: Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and…
Summary

Ref T9952. This will let me put a "Branch: [____]" control on the "Land Revision" dialog so users can choose a branch to target.

Test Plan

Used /typeahead/class/ to vet basic behavior.

Diff Detail

Repository
rP Phabricator
Branch
land2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/typeahead/DiffusionRefDatasource.php:11XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9445
Build 11251: Run Core Tests
Build 11250: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35625.Dec 10 2015, 9:18 PM
epriestley retitled this revision from to Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and refs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9952: Let "Land Revision" target branches other than master.
chad accepted this revision.Dec 10 2015, 9:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 9:23 PM
Closed by commit rP8dcdc7534d9c: Add a DiffusionRefDatasource for typeahead'ing branches, tags, bookmarks and… (authored by epriestley, committed by epriestley). · Explain WhyDec 10 2015, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
typeahead/
50 lines
repository/
query/
13 lines

Diff 35625

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionRefDatasource.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

Loading...
Phabricator · Built by Phacility