Remove subheader rule in remarkup
ClosedPublic
Actions

Authored by chad on Dec 9 2015, 5:18 PM.

Details

Reviewers

tycho.tatitscheff
epriestley

Maniphest Tasks

T9942: A <h4> remarkup title just after a <h3> title don't render correctly

Commits

Restricted Diffusion Commit
rPd9f188ee3068: Remove subheader rule in remarkup

Summary

Fixes T9942, users aren't expecting this, and we can make subheader explicit later.

Test Plan

Edit Phriction Doc

Diff Detail

Repository

rP Phabricator

Branch

subheader-rm

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9425
Build 11220: Run Core Tests
Build 11219: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35605.Dec 9 2015, 5:18 PM

chad retitled this revision from to Remove subheader rule in remarkup.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9942: A <h4> remarkup title just after a <h3> title don't render correctly.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 9 2015, 5:18 PM

epriestley accepted this revision.Dec 9 2015, 5:21 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2015, 5:21 PM

tycho.tatitscheff accepted this revision.Dec 9 2015, 5:26 PM

tycho.tatitscheff added a reviewer: tycho.tatitscheff.

Closed by commit rPd9f188ee3068: Remove subheader rule in remarkup (authored by chad, committed by chad). · Explain WhyDec 9 2015, 5:27 PM

This revision was automatically updated to reflect the committed changes.

So mucher better, ty @chad.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

7 lines

Diff 35605

View Options

resources/celerity/map.php