Page MenuHomePhabricator
Differential D14721

Clean up some custom field strings in Feed
ClosedPublic
Actions

Authored by epriestley on Dec 9 2015, 5:01 PM.
Tags
None
Referenced Files
F14056865: D14721.diff
Sat, Nov 16, 10:53 PM
F14056278: D14721.id35604.diff
Sat, Nov 16, 7:30 PM
F14015912: D14721.diff
Mon, Nov 4, 2:40 AM
F14006961: D14721.id.diff
Mon, Oct 28, 9:48 PM
F14005180: D14721.diff
Sun, Oct 27, 8:34 AM
F13999696: D14721.id35603.diff
Thu, Oct 24, 4:32 PM
F13996413: D14721.id35603.diff
Wed, Oct 23, 8:57 PM
F13996412: D14721.id35604.diff
Wed, Oct 23, 8:57 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9919: Display change between usernames for custom field of type "user" instead the PHID-USER-* in the Recent Activity feed
Commits
Restricted Diffusion Commit
rPd57cc740ca29: Clean up some custom field strings in Feed
Summary

Fixes T9919. We were missing feed strings and US English localizations for some of this stuff.

Test Plan

Before:

Screen Shot 2015-12-09 at 8.53.47 AM.png (93×1 px, 25 KB)

After:

Screen Shot 2015-12-09 at 8.59.01 AM.png (388×492 px, 59 KB)

Screen Shot 2015-12-09 at 8.58.34 AM.png (201×459 px, 30 KB)

Screen Shot 2015-12-09 at 8.58.54 AM.png (164×492 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Branch
custom1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9423
Build 11217: Run Core Tests
Build 11216: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35603.Dec 9 2015, 5:01 PM
epriestley retitled this revision from to Clean up some custom field strings in Feed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9919: Display change between usernames for custom field of type "user" instead the PHID-USER-* in the Recent Activity feed.
chad accepted this revision.Dec 9 2015, 5:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2015, 5:03 PM
Closed by commit rPd57cc740ca29: Clean up some custom field strings in Feed (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2015, 5:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
standard/
40 lines
internationalization/
translation/
18 lines

Diff 35603

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility