Paths

Table of Contentst

Differential D14715

Replace workboard task creation with EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 9 2015, 12:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 31, 8:52 PM

	Unknown Object (File)
	Fri, Jan 24, 10:20 AM

	Unknown Object (File)
	Fri, Jan 24, 10:20 AM

	Unknown Object (File)
	Fri, Jan 24, 10:20 AM

	Unknown Object (File)
	Thu, Jan 23, 11:31 PM

	Unknown Object (File)
	Tue, Jan 21, 12:58 PM

	Unknown Object (File)
	Tue, Jan 21, 11:13 AM

	Unknown Object (File)
	Dec 3 2024, 12:19 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Commits

Restricted Diffusion Commit
rPeef257250887: Replace workboard task creation with EditEngine

Summary

Ref T9908. This is the last of the things that need to swap over.

Test Plan

Created tasks from a workboard.
Created tasks in different columns.
Edited tasks.
Used ?parent=...
Verified that default edit form config now affects comment actions.
No more weird comment thing on forms, at least for now.

Diff Detail

Repository

Branch

ex32

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/project/controller/PhabricatorProjectBoardViewController.php:774	XHP16	TODO Comment
Advice	src/applications/transactions/editengine/PhabricatorEditEngine.php:1696	XHP16	TODO Comment
Advice	src/view/form/control/AphrontFormHandlesControl.php:25	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 9406
Build 11193: Run Core Tests
Build 11192: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35588.Dec 9 2015, 12:48 AM

epriestley retitled this revision from to Replace workboard task creation with EditEngine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

chad accepted this revision.Dec 9 2015, 1:50 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2015, 1:50 AM

Closed by commit rPeef257250887: Replace workboard task creation with EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2015, 1:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigWelcomeController.php

2 lines

maniphest/

editor/

ManiphestEditEngine.php

19 lines

ManiphestTransactionEditor.php

97 lines

storage/

ManiphestTransaction.php

2 lines

project/

controller/

PhabricatorProjectBoardViewController.php

22 lines

search/

engine/

PhabricatorJumpNavHandler.php

2 lines

transactions/

editengine/

PhabricatorEditEngine.php

29 lines

editengineextension/

PhabricatorCommentEditEngineExtension.php

3 lines

editfield/

PhabricatorHandlesEditField.php

37 lines

view/

PhabricatorApplicationTransactionCommentView.php

2 lines

view/

form/

control/

AphrontFormHandlesControl.php

39 lines

Diff 35588

src/applications/config/controller/PhabricatorConfigWelcomeController.php

Loading...

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/applications/search/engine/PhabricatorJumpNavHandler.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...

src/applications/transactions/editengineextension/PhabricatorCommentEditEngineExtension.php

Loading...

src/applications/transactions/editfield/PhabricatorHandlesEditField.php

Loading...

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...

src/view/form/control/AphrontFormHandlesControl.php

Loading...