Page MenuHomePhabricator
Differential D14712

Move workboard card edits to EditEngine in Maniphest
ClosedPublic
Actions

Authored by epriestley on Dec 8 2015, 10:47 PM.
Tags
None
Referenced Files
F14839638: D14712.id35582.diff
Sat, Feb 1, 12:06 AM
Unknown Object (File)
Tue, Jan 28, 7:05 PM
Unknown Object (File)
Mon, Jan 27, 4:56 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Thu, Jan 16, 4:01 AM
Unknown Object (File)
Sun, Jan 12, 12:28 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter
Commits
Restricted Diffusion Commit
rPa13ef20a0c77: Move workboard card edits to EditEngine in Maniphest
Summary

Ref T9908. This drives workboard card edits through the new stuff. Bit of copy-paste but the old one will get deleted soon.

Test Plan
  • Edited some cards.
  • Changed priority on a priority-sorted board, saw proper re-sort
  • Removed board project, saw card vanish properly.

Diff Detail

Repository
rP Phabricator
Branch
ex31
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/editor/ManiphestEditEngine.php:256XHP16TODO Comment
Advicesrc/applications/maniphest/editor/ManiphestEditEngine.php:278XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9400
Build 11184: Run Core Tests
Build 11183: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35582.Dec 8 2015, 10:47 PM
epriestley retitled this revision from to Move workboard card edits to EditEngine in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
chad accepted this revision.Dec 8 2015, 11:39 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2015, 11:39 PM
Closed by commit rPa13ef20a0c77: Move workboard card edits to EditEngine in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2015, 1:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
3 lines
editor/
107 lines
project/
view/
2 lines

Diff 35582

View Options

src/applications/maniphest/controller/ManiphestTaskEditProController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/project/view/ProjectBoardTaskCard.php

Loading...
Phabricator · Built by Phacility