Page MenuHomePhabricator
Differential D14711

Move inline edit from task lists to EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 8 2015, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 12:24 AM
Unknown Object (File)
Sat, Jan 25, 1:58 PM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Mon, Jan 20, 8:55 AM
Unknown Object (File)
Mon, Jan 13, 2:22 PM
Unknown Object (File)
Sun, Jan 12, 12:28 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter
Commits
Restricted Diffusion Commit
rP21be67e87aa1: Move inline edit from task lists to EditEngine
Summary

Ref T9908. Fixes T8903. This moves the inline edit from task lists (but not from workboards) over to editengine.

Test Plan
  • Edited a task from a draggable list.
  • Edited a task from an undraggable list.
  • Edited a task, changed projects, saw refresh show correct projects.

Diff Detail

Repository
rP Phabricator
Branch
ex30
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9399
Build 11182: Run Core Tests
Build 11181: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35581.Dec 8 2015, 10:32 PM
epriestley retitled this revision from to Move inline edit from task lists to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter, T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly.
chad accepted this revision.Dec 8 2015, 10:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2015, 10:44 PM
Closed by commit rP21be67e87aa1: Move inline edit from task lists to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 8 2015, 11:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
2 lines
1 line
editor/
48 lines
view/
2 lines
transactions/
editengine/
44 lines

Diff 35581

View Options

src/applications/maniphest/controller/ManiphestController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskEditProController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility