Page MenuHomePhabricator
Differential D14706

Make "Create Subtask" work properly in EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 8 2015, 4:12 PM.
Tags
None
Referenced Files
F14840395: D14706.diff
Sat, Feb 1, 5:52 AM
Unknown Object (File)
Thu, Jan 30, 5:08 PM
Unknown Object (File)
Sat, Jan 25, 1:14 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Fri, Jan 24, 10:20 AM
Unknown Object (File)
Sat, Jan 18, 8:00 AM
Unknown Object (File)
Sat, Jan 11, 11:22 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter
Commits
Restricted Diffusion Commit
rPd53187e10a4d: Make "Create Subtask" work properly in EditEngine
Summary

Ref T9908. This fixes "Create Subtask" so it works with the new stuff. Mostly straightforward.

Test Plan

Created some subtasks.

Diff Detail

Repository
rP Phabricator
Branch
ex22
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/controller/ManiphestTaskDetailController.php:169XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9382
Build 11157: Run Core Tests
Build 11156: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35565.Dec 8 2015, 4:12 PM
epriestley retitled this revision from to Make "Create Subtask" work properly in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
chad accepted this revision.Dec 8 2015, 4:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2015, 4:35 PM
Closed by commit rPd53187e10a4d: Make "Create Subtask" work properly in EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 8 2015, 10:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
applications/
maniphest/
controller/
20 lines
editor/
7 lines
27 lines
httpparametertype/
47 lines
30 lines
storage/
2 lines
transactions/
editengine/
2 lines
editfield/
14 lines
8 lines
view/
form/
control/
36 lines

Diff 35565

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/httpparametertype/ManiphestTaskListHTTPParameterType.php

Loading...
View Options

src/applications/maniphest/httpparametertype/ManiphestTaskPHIDResolver.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorHandlesEditField.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorPHIDListEditField.php

Loading...
View Options

src/view/form/control/AphrontFormHandlesControl.php

Loading...
Phabricator · Built by Phacility