Page MenuHomePhabricator
Differential D14689

Validate configuration of `maniphest.priorities`
ClosedPublic
Actions

Authored by epriestley on Dec 6 2015, 12:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 6, 3:04 AM
Unknown Object (File)
Apr 24 2025, 11:56 AM
Unknown Object (File)
Apr 23 2025, 10:44 AM
Unknown Object (File)
Apr 21 2025, 5:46 PM
Unknown Object (File)
Apr 21 2025, 1:27 PM
Unknown Object (File)
Apr 20 2025, 9:33 PM
Unknown Object (File)
Apr 14 2025, 6:47 AM
Unknown Object (File)
Apr 4 2025, 9:54 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T6132: Negative Maniphest priorities can be created, but not used
Commits
Restricted Diffusion Commit
rP20e6a4200dbc: Validate configuration of `maniphest.priorities`
Summary

Fixes T6132. We currently allow invalid configuration here; validate it.

Test Plan

Tried to save invalid config (negative priorities, string priorities, etc).

Diff Detail

Repository
rP Phabricator
Branch
ex11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9343
Build 11099: Run Core Tests
Build 11098: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35526.Dec 6 2015, 12:52 AM
epriestley retitled this revision from to Validate configuration of `maniphest.priorities`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T6132: Negative Maniphest priorities can be created, but not used.
chad accepted this revision.Dec 6 2015, 1:01 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2015, 1:01 AM
Closed by commit rP20e6a4200dbc: Validate configuration of `maniphest.priorities` (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2015, 1:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35526

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/config/ManiphestPriorityConfigOptionType.php

Loading...
View Options

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

Loading...
View Options

src/applications/maniphest/constants/ManiphestTaskPriority.php

Loading...
Phabricator · Built by Phacility