Page MenuHomePhabricator
Differential D14684

Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign
ClosedPublic
Actions

Authored by epriestley on Dec 5 2015, 8:38 PM.
Tags
None
Referenced Files
F14018297: D14684.id35514.diff
Tue, Nov 5, 7:50 AM
F14000933: D14684.id35514.diff
Fri, Oct 25, 2:31 AM
F13990345: D14684.diff
Tue, Oct 22, 2:54 AM
F13972324: D14684.id35515.diff
Oct 17 2024, 6:21 PM
Unknown Object (File)
Oct 1 2024, 8:49 PM
Unknown Object (File)
Oct 1 2024, 1:45 PM
Unknown Object (File)
Oct 1 2024, 10:04 AM
Unknown Object (File)
Sep 24 2024, 3:26 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9206: Herald unable to place task up for grabs
Commits
Restricted Diffusion Commit
rPbc331f0fbf54: Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign
Summary

Fixes T9206. This was also blocked on tokenizers being weird.

Also clean up some rendering stuff from the earlier changes.

Test Plan
  • Added an "unassign" rule by typing "None", per instructions in the placeholder text.
  • Ran the rule.
  • Task got unassigned.

Diff Detail

Repository
rP Phabricator
Branch
ex7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9331
Build 11081: Run Core Tests
Build 11080: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35514.Dec 5 2015, 8:38 PM
epriestley retitled this revision from to Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9206: Herald unable to place task up for grabs.
chad accepted this revision.Dec 5 2015, 8:39 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2015, 8:39 PM
Closed by commit rPbc331f0fbf54: Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
action/
16 lines
maniphest/
herald/
29 lines
8 lines

Diff 35514

View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAssignHeraldAction.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAssignOtherHeraldAction.php

Loading...
Phabricator · Built by Phacility