Differential D14678

Fix EditEngine preview/draft for first comment on a task you didn't create
ClosedPublic
Actions

Authored by epriestley on Dec 5 2015, 5:14 PM.

Details

Reviewers

chad

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction

Commits

Restricted Diffusion Commit
rP1fcdcddd5f2b: Fix EditEngine preview/draft for first comment on a task you didn't create

Summary

Ref T9132. See T9908#147038.

Test Plan

As user A, created a new task.
As user B, started typing a comment on it (with no prior activity).
Users A and B must be different.

Before patch: preview/draft don't work, trace in error log (see above).

After patch: preview/draft work.

Diff Detail

Repository

rP Phabricator

Branch

ex1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9316
Build 11060: Run Core Tests
Build 11059: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35499.Dec 5 2015, 5:14 PM

epriestley retitled this revision from to Fix EditEngine preview/draft for first comment on a task you didn't create.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

chad accepted this revision.Dec 5 2015, 5:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2015, 5:38 PM

Closed by commit rP1fcdcddd5f2b: Fix EditEngine preview/draft for first comment on a task you didn't create (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

draft/

storage/

PhabricatorVersionedDraft.php

2 lines

Diff 35499

View Options

src/applications/draft/storage/PhabricatorVersionedDraft.php

Fix EditEngine preview/draft for first comment on a task you didn't createClosedPublicActions