Differential D14677

Minor Phame polish
ClosedPublic
Actions

Authored by chad on Dec 5 2015, 4:48 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9897: Unbeta Feedback on Phame

Commits

Restricted Diffusion Commit
rP6e7940cea2c7: Minor Phame polish

Summary

Add Blogs crumb to posts
- Tidy up post edit page copy

Ref T9897

Test Plan

Review a Post, Edit Post

Diff Detail

Repository

rP Phabricator

Branch

post-crumbs

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9315
Build 11058: Run Core Tests
Build 11057: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35498.Dec 5 2015, 4:48 PM

chad retitled this revision from to Minor Phame polish.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9897: Unbeta Feedback on Phame.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 5 2015, 4:48 PM

epriestley accepted this revision.Dec 5 2015, 5:08 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/phame/controller/post/PhamePostViewController.php
31–35	(I think this is impossible now?)

This revision is now accepted and ready to land.Dec 5 2015, 5:08 PM

Closed by commit rP6e7940cea2c7: Minor Phame polish (authored by chad, committed by chad). · Explain WhyDec 5 2015, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Yeah impossible but still exist in my dev haha. I'll pull them out down the road

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

post/

PhamePostEditController.php

3 lines

PhamePostViewController.php

3 lines

Diff 35498

View Options

src/applications/phame/controller/post/PhamePostEditController.php