Page MenuHomePhabricator
Differential D14666

Limit number of EditEngine tokenizer tokens in "Owner" field UI to 1
ClosedPublic
Actions

Authored by epriestley on Dec 4 2015, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 12:57 AM
Unknown Object (File)
Thu, Dec 19, 10:43 PM
Unknown Object (File)
Thu, Dec 19, 12:46 AM
Unknown Object (File)
Tue, Dec 10, 9:44 PM
Unknown Object (File)
Mon, Dec 2, 10:55 AM
Unknown Object (File)
Sun, Dec 1, 10:06 AM
Unknown Object (File)
Wed, Nov 27, 7:58 PM
Unknown Object (File)
Sun, Nov 24, 6:50 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9132: Build an ApplicationEditor abstraction
Commits
Restricted Diffusion Commit
rPb3cf00333cfa: Limit number of EditEngine tokenizer tokens in "Owner" field UI to 1
Summary

Ref T9132. Only allow a task to have a single owner in the UI.

In Conduit, make this field appear and behave as "phid" instead of "list<phid>".

Test Plan

Edited a task with new fancy form, got limited to one owner. Assigned/unassigned. Used Conduit to assign/unassign.

Diff Detail

Repository
rP Phabricator
Branch
ee38
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9283
Build 11014: Run Core Tests
Build 11013: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35472.Dec 4 2015, 3:34 PM
epriestley retitled this revision from to Limit number of EditEngine tokens in "owners" field to 1.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9132: Build an ApplicationEditor abstraction.
chad accepted this revision.Dec 4 2015, 3:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2015, 3:35 PM
epriestley retitled this revision from Limit number of EditEngine tokens in "owners" field to 1 to Limit number of EditEngine tokenizer tokens in "Owner" field UI to 1.Dec 4 2015, 3:35 PM
epriestley edited edge metadata.
Closed by commit rPb3cf00333cfa: Limit number of EditEngine tokenizer tokens in "Owner" field UI to 1 (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
editor/
14 lines
transactions/
editfield/
32 lines
4 lines

Diff 35472

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorPHIDListEditField.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorTokenizerEditField.php

Loading...
Phabricator · Built by Phacility