Page MenuHomePhabricator

Implement versioned drafts in EditEngine comment forms
ClosedPublic

Authored by epriestley on Dec 2 2015, 8:58 PM.
Tags
None
Referenced Files
F14051571: D14640.diff
Fri, Nov 15, 2:02 AM
F14037752: D14640.diff
Sun, Nov 10, 6:46 PM
F14022935: D14640.diff
Wed, Nov 6, 9:05 PM
F14022076: D14640.id.diff
Wed, Nov 6, 3:10 PM
F14011782: D14640.diff
Fri, Nov 1, 5:15 AM
F13983790: D14640.id35418.diff
Sun, Oct 20, 8:38 AM
F13977410: D14640.diff
Oct 18 2024, 6:28 PM
F13960244: D14640.id35446.diff
Oct 14 2024, 10:35 PM
Subscribers
None

Details

Summary

Ref T9132. Fixes T5031. This approximately implements the plan described in T5031#67988:

When we recieve a preview request, don't write a draft if the form is from a version of the object before the last update the viewer made.

This should fix the race-related (?) zombie draft comments that sometimes show up.

I just added a new object for this stuff to make it easier to do stacked actions (or whatever we end up with) a little later, since I needed to do some schema adjustments anyway.

Test Plan
  • Typed some text.
  • Reloaded page.
  • Draft stayed there.
  • Tried real hard to get it to ghost by submitting stuff in multiple windows and typing a lot and couldn't, although I didn't bother specifically narrowing down the race condition.

Diff Detail

Repository
rP Phabricator
Branch
ee31
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/transactions/editengine/PhabricatorEditEngine.php:1020XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9229
Build 10929: Run Core Tests
Build 10928: arc lint + arc unit