Page MenuHomePhabricator
Differential D14621

Make multiple paragraphs in blockquotes space properly
ClosedPublic
Actions

Authored by chad on Dec 1 2015, 5:38 PM.
Tags
None
Referenced Files
F14477960: D14621.diff
Sat, Dec 28, 4:02 PM
Unknown Object (File)
Tue, Dec 24, 2:37 AM
Unknown Object (File)
Mon, Dec 16, 5:28 PM
Unknown Object (File)
Thu, Dec 12, 5:36 AM
Unknown Object (File)
Tue, Dec 10, 12:41 PM
Unknown Object (File)
Tue, Dec 3, 9:23 AM
Unknown Object (File)
Mon, Dec 2, 2:59 AM
Unknown Object (File)
Sun, Dec 1, 10:04 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9878: Remarkup rendering inside quoted sections does not distinguish paragraphs
Commits
Restricted Diffusion Commit
rP774d2db8dc78: Make multiple paragraphs in blockquotes space properly
Summary

Fixes T9878

Test Plan

Quote multiple paragraphs, multiple lists

pasted_file (364×498 px, 32 KB)

Diff Detail

Repository
rP Phabricator
Branch
remarkup-blockquote
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9182
Build 10856: Run Core Tests
Build 10855: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35371.Dec 1 2015, 5:38 PM
chad retitled this revision from to Make multiple paragraphs in blockquotes space properly.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9878: Remarkup rendering inside quoted sections does not distinguish paragraphs.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 1 2015, 5:38 PM
epriestley accepted this revision.Dec 1 2015, 5:48 PM
epriestley edited edge metadata.

I also caught another one, lists in blockquotes are a bit funky (too much bottom margin).

  • lists
This revision is now accepted and ready to land.Dec 1 2015, 5:48 PM
chad updated this revision to Diff 35372.Dec 1 2015, 5:51 PM
chad edited edge metadata.
  • squash the last child specifically
chad edited the test plan for this revision. (Show Details)Dec 1 2015, 5:52 PM
Closed by commit rP774d2db8dc78: Make multiple paragraphs in blockquotes space properly (authored by chad, committed by chad). · Explain WhyDec 1 2015, 5:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
4 lines

Diff 35372

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility