Page MenuHomePhabricator
Differential D14605

Correctly implementing mailkey for Phurl
ClosedPublic
Actions

Authored by lpriestley on Nov 30 2015, 2:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 1:38 PM
Unknown Object (File)
Sat, Jan 25, 1:38 PM
Unknown Object (File)
Sat, Jan 25, 1:38 PM
Unknown Object (File)
Sat, Jan 25, 10:35 AM
Unknown Object (File)
Sat, Jan 25, 8:52 AM
Unknown Object (File)
Fri, Jan 24, 10:09 AM
Unknown Object (File)
Thu, Jan 23, 8:23 PM
Unknown Object (File)
Tue, Dec 31, 10:07 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP47a5ebb4fec2: Correctly implementing mailkey for Phurl
Summary

Re T6049, Correctly implementing mailkey for Phurl

Test Plan

Edit Phurl URL, receive email.

Diff Detail

Repository
rP Phabricator
Branch
phurlmailkey
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9137
Build 10784: Run Core Tests
Build 10783: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 35326.Nov 30 2015, 2:48 PM
lpriestley retitled this revision from to Correctly implementing mailkey for Phurl.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 2:48 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 30 2015, 6:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 6:34 PM
Closed by commit rP47a5ebb4fec2: Correctly implementing mailkey for Phurl (authored by lpriestley, committed by lpriestley). · Explain WhyNov 30 2015, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
18 lines
src/
applications/
phurl/
editor/
6 lines
storage/
10 lines
5 lines

Diff 35326

View Options

resources/sql/autopatches/20151130.phurl.mailkey.1.sql

Loading...
View Options

resources/sql/autopatches/20151130.phurl.mailkey.2.php

Loading...
View Options

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php

Loading...
View Options

src/applications/phurl/storage/PhabricatorPhurlURL.php

Loading...
View Options

src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php

Loading...
Phabricator · Built by Phacility