Page MenuHomePhabricator
Differential D14575

Pass recently applied transactions to HeraldAdapters
ClosedPublic
Actions

Authored by epriestley on Nov 26 2015, 2:58 PM.
Tags
None
Referenced Files
F14372121: D14575.id35268.diff
Fri, Dec 20, 7:36 PM
F14363313: D14575.diff
Fri, Dec 20, 1:58 PM
Unknown Object (File)
Wed, Dec 11, 7:32 AM
Unknown Object (File)
Tue, Dec 10, 8:30 PM
Unknown Object (File)
Tue, Dec 10, 8:30 PM
Unknown Object (File)
Tue, Dec 10, 8:28 PM
Unknown Object (File)
Tue, Dec 10, 8:23 PM
Unknown Object (File)
Mon, Dec 9, 6:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events
Commits
Restricted Diffusion Commit
rPfc1c36106daf: Pass recently applied transactions to HeraldAdapters
Summary

Ref T9851. See T9860. This adds a missing capability to custom HeraldActions, to pave the way for removing the obsolete/undesirable WILLEDITTASK and DIDEDITTASK events.

Test Plan

See T9860 for a replacement action.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35266.Nov 26 2015, 2:58 PM
epriestley retitled this revision from to Pass recently applied transactions to HeraldAdapters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.
epriestley mentioned this in T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.Nov 26 2015, 3:27 PM
chad accepted this revision.Nov 26 2015, 4:31 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 26 2015, 4:31 PM
Closed by commit rPfc1c36106daf: Pass recently applied transactions to HeraldAdapters (authored by epriestley, committed by epriestley). · Explain WhyNov 26 2015, 4:53 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T13283: When Herald acts, include the transaction group as part of the "state" it acts upon.May 13 2019, 4:56 PM
epriestley mentioned this in D20518: In Herald, save applied transaction PHIDs in the transcript and display them in the UI.May 13 2019, 5:02 PM
epriestley mentioned this in rP046888ac2e56: In Herald, save applied transaction PHIDs in the transcript and display them in….May 16 2019, 4:58 PM

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
31 lines
transactions/
editor/
9 lines

Diff 35268

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility