Page MenuHomePhabricator
Differential D14288

Add a CircleCI webhook
ClosedPublic
Actions

Authored by epriestley on Oct 15 2015, 4:38 PM.
Tags
None
Referenced Files
F18847728: D14288.diff
Thu, Oct 30, 1:52 AM
F18844328: D14288.id34489.diff
Wed, Oct 29, 4:38 AM
F18844327: D14288.id37365.diff
Wed, Oct 29, 4:38 AM
F18844326: D14288.id35251.diff
Wed, Oct 29, 4:38 AM
F18844301: D14288.id37383.diff
Wed, Oct 29, 4:30 AM
F18783580: D14288.id.diff
Mon, Oct 13, 8:14 AM
F18759397: D14288.id37383.diff
Mon, Oct 6, 3:35 AM
F18731482: D14288.diff
Sep 30 2025, 2:58 PM
View All Files
Subscribers
dpaola2
• JustinTulloss

Details

Reviewers
chad
Maniphest Tasks
T9456: Evaluate upstream support for third-party build systems
Commits
Restricted Diffusion Commit
rP7868c5d7d0fd: Add a CircleCI webhook
Summary

Ref T9456. This makes everything work, except that CircleCI doesn't fetch tags which are not ancestors of branch heads.

Test Plan

Ran passing builds through CircleCI.

Diff Detail

Repository
rP Phabricator
Branch
circle3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9060
Build 10662: Run Core Tests
Build 10661: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34489.Oct 15 2015, 4:38 PM
epriestley retitled this revision from to Add a CircleCI webhook.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9456: Evaluate upstream support for third-party build systems.
chad accepted this revision.Oct 15 2015, 4:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 15 2015, 4:48 PM
epriestley updated this revision to Diff 35251.Nov 25 2015, 3:18 PM
epriestley edited edge metadata.
  • Rebase after possible CircleCI changes.
joshma mentioned this in D14286: Add a "Build with CircleCI" build step.Feb 10 2016, 10:15 PM
• JustinTulloss added a subscriber: • JustinTulloss.Mar 5 2016, 10:46 PM
dpaola2 added a subscriber: dpaola2.Mar 19 2016, 10:16 PM
epriestley updated this revision to Diff 37365.Mar 19 2016, 10:49 PM
  • Rebase.
  • No substantive changes.
epriestley mentioned this in T9456: Evaluate upstream support for third-party build systems.Mar 19 2016, 10:51 PM
epriestley updated this revision to Diff 37383.Mar 22 2016, 7:11 PM
  • Treat "fixed" from CircleCI as a "pass". This status means "previously failed, but now passed" as far as I can tell.
Closed by commit rP7868c5d7d0fd: Add a CircleCI webhook (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2016, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35251

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterCircleCIHookController.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterCircleCIBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildMessage.php

Loading...
Phabricator · Built by Phacility