Page MenuHomePhabricator
Differential D14552

Use PHUIRemarkupPreviewView in Phame
ClosedPublic
Actions

Authored by chad on Nov 23 2015, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 1:53 AM
Unknown Object (File)
Thu, Feb 6, 11:02 PM
Unknown Object (File)
Sun, Feb 2, 3:43 PM
Unknown Object (File)
Thu, Jan 30, 6:24 AM
Unknown Object (File)
Wed, Jan 29, 10:35 PM
Unknown Object (File)
Wed, Jan 29, 10:35 PM
Unknown Object (File)
Wed, Jan 29, 10:35 PM
Unknown Object (File)
Wed, Jan 29, 10:35 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPdf7f21b4e811: Use PHUIRemarkupPreviewView in Phame
Summary

Reuse PHUIMarkupPreviewView in Phame for consistency, less custom code. Also, doesn't work (JS issue).

Test Plan

New Post, Edit Post, Save Post

Diff Detail

Repository
rP Phabricator
Branch
phame-preview
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 9009
Build 10585: Run Core Tests
Build 10584: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
182 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
164 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
0 msAlmanacNamesTestCase::Unknown Unit Message ("")
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
View Full Test Results (2 Failed · 301 Passed)

Event Timeline

chad updated this revision to Diff 35198.Nov 23 2015, 5:52 PM
chad retitled this revision from to Use PHUIRemarkupPreviewView in Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 23 2015, 5:52 PM
chad added inline comments.Nov 23 2015, 5:53 PM
webroot/rsrc/js/application/phame/phame-post-preview.js
65–73

I want to dump the URI/Preview stuff, but I don't understand JS at all, nor JX. How can I simplify this?

epriestley edited edge metadata.Nov 23 2015, 5:55 PM

Maybe?

src/applications/phame/controller/post/PhamePostEditController.php
184–189

Delete this.

webroot/rsrc/js/application/phame/phame-post-preview.js
1

Then delete this entire file.

chad added a comment.Nov 23 2015, 5:56 PM

No I went down that path, it prefills the "Phame Title" slug, which is nice.

epriestley added a comment.Nov 23 2015, 6:00 PM

Ah. Try just deleting:

var getdata = ...
var request = ...
var trigger = ...
(3x) JX.DOM.listen(..., ..., trigger);
request.start()
chad updated this revision to Diff 35202.Nov 23 2015, 6:30 PM
chad edited edge metadata.
  • yay
epriestley accepted this revision.Nov 23 2015, 6:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 6:31 PM
Closed by commit rPdf7f21b4e811: Use PHUIRemarkupPreviewView in Phame (authored by chad, committed by chad). · Explain WhyNov 23 2015, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
2 lines
applications/
phame/
application/
2 lines
controller/
post/
22 lines
view/
phui/
2 lines
webroot/
rsrc/
js/
application/
phame/
7 lines

Diff 35198

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostPreviewController.php

Loading...
View Options

src/view/phui/PHUIRemarkupPreviewPanel.php

Loading...
View Options

webroot/rsrc/js/application/phame/phame-post-preview.js

Loading...
Phabricator · Built by Phacility