Ref T9132. This just makes edited forms do something, albeit not anything very useful yet.
You can now edit a form and:
- Retitle it;
- add a preamble (instructions on top of the form); and
- reorder the form's fields.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T9132: Build an ApplicationEditor abstraction
- Commits
- Restricted Diffusion Commit
rP9aee90f8c1e8: Allow form configurations to retitle and reorder forms and add preambles
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- eengine16
- Lint
Lint Errors Severity Location Code Message Error src/applications/base/PhabricatorApplication.php:300 XHP86 Unsafe Usage of Dynamic String Error src/applications/base/PhabricatorApplication.php:302 XHP86 Unsafe Usage of Dynamic String Warning webroot/rsrc/js/application/transactions/behavior-reorder-fields.js:1 JAVELIN5 `javelinsymbols` Not In Path - Unit
Tests Passed - Build Status
Buildable 8898 Build 10418: Run Core Tests Build 10417: arc lint + arc unit
Event Timeline
Comment Actions
what is this magic
(I gather this editor refactoring is designed to support form editing in Nuance, and as part of that, you're unifying all of the other forms in Phabricator to use the same system)