Page MenuHomePhabricator
Differential D14491

Fix history link in Diffusion non-root browse views
ClosedPublic
Actions

Authored by epriestley on Nov 16 2015, 4:40 PM.
Tags
None
Referenced Files
F15533590: D14491.id35060.diff
Wed, Apr 23, 8:41 PM
F15512006: D14491.id35061.diff
Thu, Apr 17, 7:19 AM
F15509301: D14491.id.diff
Wed, Apr 16, 11:01 AM
F15502264: D14491.id35061.diff
Sun, Apr 13, 11:23 PM
F15492272: D14491.id.diff
Sat, Apr 12, 12:56 PM
F15491736: D14491.id35060.diff
Sat, Apr 12, 6:54 AM
F15490415: D14491.diff
Fri, Apr 11, 5:11 PM
F15477255: D14491.diff
Mon, Apr 7, 1:08 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9798: History icon url in the content browser of diffusion does not include file path
Commits
Restricted Diffusion Commit
rP5963c4c9e06d: Fix history link in Diffusion non-root browse views
Summary

Fixes T9798. That task has good repro instructions.

In sub-views, we don't link the "History" icon correctly -- we only link it to history/README instead of history/path/to/README. Add the full path.

Also canonicalize the paths in a slightly prettier and more consistenty way.

Test Plan

Viewed root and non-root browse tables, saw links show up properly.

Diff Detail

Repository
rP Phabricator
Branch
hlink1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8870
Build 10375: Run Core Tests
Build 10374: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35060.Nov 16 2015, 4:40 PM
epriestley retitled this revision from to Fix history link in Diffusion non-root browse views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9798: History icon url in the content browser of diffusion does not include file path.
chad accepted this revision.Nov 16 2015, 4:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 4:49 PM
Closed by commit rP5963c4c9e06d: Fix history link in Diffusion non-root browse views (authored by epriestley, committed by epriestley). · Explain WhyNov 16 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
view/
17 lines

Diff 35060

View Options

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...
Phabricator · Built by Phacility