Page MenuHomePhabricator

Fix history link in Diffusion non-root browse views
ClosedPublic

Authored by epriestley on Nov 16 2015, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 5:17 AM
Unknown Object (File)
Wed, Feb 19, 8:46 PM
Unknown Object (File)
Thu, Feb 13, 11:26 PM
Unknown Object (File)
Sun, Feb 9, 2:35 PM
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Unknown Object (File)
Sat, Feb 8, 11:49 PM
Subscribers
None

Details

Summary

Fixes T9798. That task has good repro instructions.

In sub-views, we don't link the "History" icon correctly -- we only link it to history/README instead of history/path/to/README. Add the full path.

Also canonicalize the paths in a slightly prettier and more consistenty way.

Test Plan

Viewed root and non-root browse tables, saw links show up properly.

Diff Detail

Repository
rP Phabricator
Branch
hlink1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8870
Build 10375: Run Core Tests
Build 10374: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix history link in Diffusion non-root browse views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 4:49 PM
This revision was automatically updated to reflect the committed changes.