Page MenuHomePhabricator
Differential D14491

Fix history link in Diffusion non-root browse views
ClosedPublic
Actions

Authored by epriestley on Nov 16 2015, 4:40 PM.
Tags
None
Referenced Files
F15385210: D14491.id35060.diff
Fri, Mar 14, 9:58 PM
F15381350: D14491.diff
Fri, Mar 14, 7:10 AM
F15375473: D14491.id35060.diff
Wed, Mar 12, 11:22 PM
F15375118: D14491.id35060.diff
Wed, Mar 12, 9:42 PM
F15333097: D14491.diff
Fri, Mar 7, 11:51 PM
F15332414: D14491.diff
Fri, Mar 7, 5:22 PM
Unknown Object (File)
Wed, Feb 26, 5:17 AM
Unknown Object (File)
Wed, Feb 19, 8:46 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9798: History icon url in the content browser of diffusion does not include file path
Commits
Restricted Diffusion Commit
rP5963c4c9e06d: Fix history link in Diffusion non-root browse views
Summary

Fixes T9798. That task has good repro instructions.

In sub-views, we don't link the "History" icon correctly -- we only link it to history/README instead of history/path/to/README. Add the full path.

Also canonicalize the paths in a slightly prettier and more consistenty way.

Test Plan

Viewed root and non-root browse tables, saw links show up properly.

Diff Detail

Repository
rP Phabricator
Branch
hlink1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8870
Build 10375: Run Core Tests
Build 10374: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35060.Nov 16 2015, 4:40 PM
epriestley retitled this revision from to Fix history link in Diffusion non-root browse views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9798: History icon url in the content browser of diffusion does not include file path.
chad accepted this revision.Nov 16 2015, 4:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 4:49 PM
Closed by commit rP5963c4c9e06d: Fix history link in Diffusion non-root browse views (authored by epriestley, committed by epriestley). · Explain WhyNov 16 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
view/
17 lines

Diff 35060

View Options

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...
Phabricator · Built by Phacility