Adjust arcanist SVN patch workflow to correctly support directory move
Needs ReviewPublic
Actions

Authored by • andrask on Nov 14 2015, 1:07 PM.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers
Arcanist

Maniphest Tasks

T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously

Summary

Detailed description is T9784

Test Plan

move dir in svn repo
arc diff --create
svn revert -R .
arc patch <D num>

Process will end with various errors and warnings without this patch.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/workflow/ArcanistPatchWorkflow.php:534	XHP24	Brace Placement
Warning	src/workflow/ArcanistPatchWorkflow.php:843	TXT3	Line Too Long
Advice	src/workflow/ArcanistPatchWorkflow.php:557	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 8839
Build 10321: arc lint + arc unit

Event Timeline

• andrask updated this revision to Diff 35029.Nov 14 2015, 1:07 PM

• andrask retitled this revision from to Adjust arcanist SVN patch workflow to correctly support directory move.

• andrask updated this object.

• andrask edited the test plan for this revision. (Show Details)

• andrask added a reviewer: Arcanist.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 14 2015, 1:07 PM

Herald added a subscriber: epriestley. · View Herald Transcript

fix linting issues

• andrask added a task: T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.Nov 14 2015, 1:19 PM

• andrask mentioned this in T9859: `arc diff` allows addition of empty directories in SVN but `arc patch` creates files.Nov 28 2015, 8:51 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistPatchWorkflow.php

47 lines

Diff 35029

View Options

src/workflow/ArcanistPatchWorkflow.php

Adjust arcanist SVN patch workflow to correctly support directory moveNeeds ReviewPublicActions