Fix missing EditEngineConfig on indirect pathway through conduit.query
ClosedPublic
Actions

Authored by epriestley on Nov 12 2015, 7:15 PM.

Details

Reviewers

chad

Maniphest Tasks

T9772: Fatal error when running conduit.query

Commits

Restricted Diffusion Commit
rP7e3d8082dfc5: Fix missing EditEngineConfig on indirect pathway through conduit.query

Summary

Fixes T9772. We now need an EditEngineConfiguration to do interesting things with EditEngine, but this public API wasn't properly making sure we have one.

Test Plan

Called conduit.query from web console. Fatal prior to patch; success afterward.

Diff Detail

Repository

rP Phabricator

Branch

eengine12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8806
Build 10272: Run Core Tests
Build 10271: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34996.Nov 12 2015, 7:15 PM

epriestley retitled this revision from to Fix missing EditEngineConfig on indirect pathway through conduit.query.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9772: Fatal error when running conduit.query.

chad accepted this revision.Nov 12 2015, 7:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 12 2015, 7:15 PM

Closed by commit rP7e3d8082dfc5: Fix missing EditEngineConfig on indirect pathway through conduit.query (authored by epriestley, committed by epriestley). · Explain WhyNov 12 2015, 7:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

5 lines

Diff 34996

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Fix missing EditEngineConfig on indirect pathway through conduit.queryClosedPublicActions