Page MenuHomePhabricator
Differential D14456

Always override `auth.email-domains` when running unit tests
ClosedPublic
Actions

Authored by lpriestley on Nov 10 2015, 6:11 PM.
Tags
None
Referenced Files
F19303406: D14456.id34950.diff
Wed, Dec 24, 12:15 AM
F19298474: D14456.id.diff
Tue, Dec 23, 1:33 PM
F18813069: D14456.id.diff
Oct 20 2025, 1:48 PM
F18808129: D14456.diff
Oct 19 2025, 4:51 AM
F18804693: D14456.id34951.diff
Oct 18 2025, 10:40 AM
F18735512: D14456.diff
Oct 1 2025, 1:51 AM
F18712839: D14456.id.diff
Sep 29 2025, 5:33 AM
F18671975: D14456.id.diff
Sep 25 2025, 6:09 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9689: unit test failure when auth.email-domains is configured
Commits
Restricted Diffusion Commit
rP64ad44cffb24: Always override `auth.email-domains` when running unit tests
Summary

Fixes T9689, Always override auth.email-domains when running unit tests

Test Plan
  • Set auth.email-domains
  • Run arc unit --everything.

Observe no errors.

Diff Detail

Repository
rP Phabricator
Branch
configauthdomainunittestoverride
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8760
Build 10191: Run Core Tests
Build 10190: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34950.Nov 10 2015, 6:11 PM
lpriestley retitled this revision from to Always override `auth.email-domains` when running unit tests.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T9689: unit test failure when auth.email-domains is configured.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 10 2015, 6:11 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 10 2015, 6:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 6:12 PM
Closed by commit rP64ad44cffb24: Always override `auth.email-domains` when running unit tests (authored by lpriestley, committed by lpriestley). · Explain WhyNov 10 2015, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
__tests__/
1 line
infrastructure/
testing/
4 lines

Diff 34950

View Options

src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php

Loading...
View Options

src/infrastructure/testing/PhabricatorTestCase.php

Loading...
Phabricator · Built by Phacility