Adds commenting to Phame Posts, also testing a new "document comment style". Unsure about it but Phame is a prototype so good place to explore.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T9746: Figure out commenting in Phame
- Commits
- Restricted Diffusion Commit
rPb315f61f4976: Add comments to internal Phame Posts
Leave some comments, see some comments, test show/hide.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phame-comments
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8746 Build 10167: Run Core Tests Build 10166: arc lint + arc unit
Event Timeline
| src/applications/phame/controller/post/PhamePostViewController.php | ||
|---|---|---|
| 81–82 | Thinking about this, do we really even need to impose this restriction, given that stuff is internal-facing and we have other stuff like "subscribing to the blog subscribes to posts"? Maybe just leave it off for now until we find that the timeline is too spammy in practice and can't clean it up in other ways? | |
Comment Actions
I don't disagree on fundamentals, but it changes my work from being "design a commenting tool" to "redesign timeline". It might be I still end up at the same place, but right now I want to explore the first one a bit more.