When accessing an invalid URL on the short Phurl domain, users should see informative message
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP2b5bb642c075: Provide a more informative alternative to 404 on invalid shortened Phurl URL
Open URL in the previously configured Phurl short domain such as https://www.zz.us and see dialog with message. Open https://www.zz.us/u/123 for a valid U123 Phurl and access destination URL.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phurlshortdomaininvalidmessage
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8741 Build 10158: Run Core Tests Build 10157: arc lint + arc unit
Event Timeline
Comment Actions
Very minor, but we should probably set the HTTP response code to 404 on these. You should be able to do something like this:
$dialog = $this->newDialog() ->... return id(new AphrontDialogResponse()) ->setDialog($dialog) ->setResponseCode(404);