Page MenuHomePhabricator
Differential D14448

Remove comment plugins from Phame
ClosedPublic
Actions

Authored by chad on Nov 9 2015, 7:45 PM.
Tags
None
Referenced Files
F14352825: D14448.diff
Thu, Dec 19, 2:53 PM
Unknown Object (File)
Tue, Dec 17, 9:09 AM
Unknown Object (File)
Wed, Dec 4, 2:44 AM
Unknown Object (File)
Sun, Dec 1, 11:08 PM
Unknown Object (File)
Thu, Nov 28, 3:02 PM
Unknown Object (File)
Thu, Nov 28, 3:01 PM
Unknown Object (File)
Thu, Nov 28, 3:01 PM
Unknown Object (File)
Thu, Nov 28, 2:29 PM
View All Files
Subscribers
btrahan
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9746: Figure out commenting in Phame
Commits
Restricted Diffusion Commit
rPada7d45a00d9: Remove comment plugins from Phame
Summary

Cleaning up house, may revisit in a v2. Removes ability to set Disqus or Facebook comments as comment system on Phame Posts.

Test Plan

Create blog, create post, edit blog, view live pages.

Diff Detail

Repository
rP Phabricator
Branch
phame-remove-comments
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8734
Build 10147: Run Core Tests
Build 10146: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34923.Nov 9 2015, 7:45 PM
chad retitled this revision from to Remove comment plugins from Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 9 2015, 7:45 PM
epriestley accepted this revision.Nov 9 2015, 7:50 PM
epriestley edited edge metadata.

awwyiss

This revision is now accepted and ready to land.Nov 9 2015, 7:50 PM
chad added a subscriber: btrahan.Nov 9 2015, 7:50 PM

*pours one out for @btrahan

chad added a task: T9746: Figure out commenting in Phame.Nov 9 2015, 7:51 PM
Closed by commit rPada7d45a00d9: Remove comment plugins from Phame (authored by chad, committed by chad). · Explain WhyNov 9 2015, 7:52 PM
This revision was automatically updated to reflect the committed changes.
vlada added a subscriber: vlada.Nov 18 2015, 3:05 PM
vlada removed a subscriber: vlada.Nov 18 2015, 3:08 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
config/
option/
phame/
controller/
post/
11 lines
editor/
7 lines
storage/
31 lines
15 lines
view/
111 lines

Diff 34923

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/option/PhabricatorDisqusConfigOptions.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phame/storage/PhamePostTransaction.php

Loading...
View Options

src/applications/phame/view/PhamePostView.php

Loading...
Phabricator · Built by Phacility