Page MenuHomePhabricator

Fix no-op transaction error on `paste.create` Conduit API method
ClosedPublic

Authored by epriestley on Nov 8 2015, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 27 2025, 5:30 PM
Unknown Object (File)
May 3 2025, 1:16 PM
Unknown Object (File)
Apr 28 2025, 10:37 AM
Unknown Object (File)
Apr 26 2025, 7:01 PM
Unknown Object (File)
Apr 26 2025, 4:49 PM
Unknown Object (File)
Apr 22 2025, 11:29 PM
Unknown Object (File)
Apr 13 2025, 8:55 AM
Unknown Object (File)
Apr 9 2025, 9:11 PM
Subscribers
None

Details

Summary

Fixes T9735. I changed how the TYPE_LANGUAGE transction works a little but that accidentally tripped an error condition in paste.create.

  • Don't bail on no-effect transactions to paste.create (like not setting a language).
  • When a transaction type has no tailored UI message, make it easier to figure out which transaction is problematic.
Test Plan

Ran arc paste ... locally. Got an error before the patch, clean paste creation afterward.

Diff Detail

Repository
rP Phabricator
Branch
paste1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8702
Build 10101: Run Core Tests
Build 10100: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix no-op transaction error on `paste.create` Conduit API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2015, 3:03 PM
This revision was automatically updated to reflect the committed changes.