Paths

Table of Contentst

Differential D14440

Fix no-op transaction error on `paste.create` Conduit API method
ClosedPublic
Actions

Authored by epriestley on Nov 8 2015, 1:24 PM.

Details

Reviewers

chad

Maniphest Tasks

T9735: Fix `paste.create` conduit method in the wake of edit engine support

Commits

Restricted Diffusion Commit
rP111c48b21024: (stable) Fix no-op transaction error on `paste.create` Conduit API method
rP2b41ed01c692: Fix no-op transaction error on `paste.create` Conduit API method

Summary

Fixes T9735. I changed how the TYPE_LANGUAGE transction works a little but that accidentally tripped an error condition in paste.create.

Don't bail on no-effect transactions to paste.create (like not setting a language).
When a transaction type has no tailored UI message, make it easier to figure out which transaction is problematic.

Test Plan

Ran arc paste ... locally. Got an error before the patch, clean paste creation afterward.

Diff Detail

Repository

rP Phabricator

Branch

paste1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8702
Build 10101: Run Core Tests
Build 10100: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34893.Nov 8 2015, 1:24 PM

epriestley retitled this revision from to Fix no-op transaction error on `paste.create` Conduit API method.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9735: Fix `paste.create` conduit method in the wake of edit engine support.

chad accepted this revision.Nov 8 2015, 3:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 8 2015, 3:03 PM

Closed by commit rP2b41ed01c692: Fix no-op transaction error on `paste.create` Conduit API method (authored by epriestley, committed by epriestley). · Explain WhyNov 8 2015, 3:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

paste/

conduit/

PasteCreateConduitAPIMethod.php

1 line

transactions/

storage/

PhabricatorApplicationTransaction.php

4 lines

Diff 34893

View Options

src/applications/paste/conduit/PasteCreateConduitAPIMethod.php