Page MenuHomePhabricator

Add a transaction for PhamePost visibility
ClosedPublic

Authored by chad on Nov 7 2015, 4:10 AM.
Tags
None
Referenced Files
F15541662: D14429.diff
Fri, Apr 25, 12:52 PM
F15525611: D14429.id34864.diff
Mon, Apr 21, 3:38 PM
F15525609: D14429.id34865.diff
Mon, Apr 21, 3:38 PM
F15523383: D14429.id34867.diff
Mon, Apr 21, 1:03 AM
F15517763: D14429.id34864.diff
Sat, Apr 19, 8:15 AM
F15517173: D14429.id34867.diff
Sat, Apr 19, 12:42 AM
F15517172: D14429.id34865.diff
Sat, Apr 19, 12:42 AM
F15517171: D14429.id34864.diff
Sat, Apr 19, 12:42 AM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
Restricted Diffusion Commit
rPf8b085c574ae: Add a transaction for PhamePost visibility
Summary

Adds ability to set visibility when authoring a Post. New default is "Visible". If you write a post and save it as a Draft, and later click publish, a feed story and mail will go out.

Test Plan

Write a new Post, see feed story and get email. Write a new Draft, get nothing. Click Publish, see story and email.

Diff Detail

Repository
rP Phabricator
Branch
phame-visibility
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8671
Build 10053: Run Core Tests
Build 10052: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add a transaction for PhamePost visibility.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/storage/PhamePostTransaction.php
219

if (strlen($text)) is a slightly better check here, so we summarize post bodies like "0" and "0.0" correctly.

This revision is now accepted and ready to land.Nov 7 2015, 12:24 PM

(I think this application behavior is a good one, too.)

This revision was automatically updated to reflect the committed changes.