Page MenuHomePhabricator

Add a transaction for PhamePost visibility
ClosedPublic

Authored by chad on Nov 7 2015, 4:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 3:50 AM
Unknown Object (File)
Fri, Feb 14, 3:50 AM
Unknown Object (File)
Sat, Feb 8, 11:43 PM
Unknown Object (File)
Sat, Feb 1, 10:27 AM
Unknown Object (File)
Thu, Jan 30, 7:42 AM
Unknown Object (File)
Mon, Jan 27, 7:10 PM
Unknown Object (File)
Mon, Jan 27, 7:10 PM
Unknown Object (File)
Mon, Jan 27, 7:10 PM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
Restricted Diffusion Commit
rPf8b085c574ae: Add a transaction for PhamePost visibility
Summary

Adds ability to set visibility when authoring a Post. New default is "Visible". If you write a post and save it as a Draft, and later click publish, a feed story and mail will go out.

Test Plan

Write a new Post, see feed story and get email. Write a new Draft, get nothing. Click Publish, see story and email.

Diff Detail

Repository
rP Phabricator
Branch
phame-visibility
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8671
Build 10053: Run Core Tests
Build 10052: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add a transaction for PhamePost visibility.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/storage/PhamePostTransaction.php
219

if (strlen($text)) is a slightly better check here, so we summarize post bodies like "0" and "0.0" correctly.

This revision is now accepted and ready to land.Nov 7 2015, 12:24 PM

(I think this application behavior is a good one, too.)

This revision was automatically updated to reflect the committed changes.