Page MenuHomePhabricator
Differential D14426

Add mail/feed support to PhamePost
ClosedPublic
Actions

Authored by chad on Nov 6 2015, 9:48 PM.
Tags
None
Referenced Files
F15444536: D14426.id34860.diff
Thu, Mar 27, 9:57 AM
F15441390: D14426.diff
Wed, Mar 26, 5:56 PM
F15436231: D14426.id34855.diff
Tue, Mar 25, 12:45 PM
F15416233: D14426.id34860.diff
Thu, Mar 20, 9:57 AM
F15416232: D14426.id34853.diff
Thu, Mar 20, 9:57 AM
F15416231: D14426.id34859.diff
Thu, Mar 20, 9:57 AM
F15416230: D14426.id34855.diff
Thu, Mar 20, 9:57 AM
F15416190: D14426.diff
Thu, Mar 20, 9:48 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
Restricted Diffusion Commit
rP6fe2377cc2c5: Add mail/feed support to PhamePost
Summary

Allows feed stories and mail for new Phame Posts.

Test Plan

Write Post, Get Mail

Diff Detail

Repository
rP Phabricator
Branch
phame-post-feed
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phame/editor/PhamePostEditor.php:166XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8659
Build 10032: Run Core Tests
Build 10031: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34853.Nov 6 2015, 9:48 PM
chad retitled this revision from to Add mail/feed support to PhamePost.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 6 2015, 9:48 PM
chad updated this revision to Diff 34855.Nov 6 2015, 10:16 PM
  • fixors
chad planned changes to this revision.Nov 6 2015, 10:17 PM

I have mail and feed working, so going to polish it up a bit and re-submit.

chad updated this revision to Diff 34859.Nov 7 2015, 1:13 AM
  • fixors
  • check isDraft
  • Include BODY in new Phame Posts
chad updated this object.Nov 7 2015, 1:14 AM
chad added inline comments.Nov 7 2015, 1:18 AM
src/applications/phame/editor/PhamePostEditor.php
152

Will follow up on next diff, but by default all new posts are "drafts" and there is no transaction for "publish". I hard coded testing emails and feed stories.

I plan to default new posts to "published" and add a transaction type for visibility changes.

epriestley accepted this revision.Nov 7 2015, 1:34 AM
epriestley edited edge metadata.

Couple minor inlines.

src/applications/phame/editor/PhamePostEditor.php
169

Just getBlogPHID(), not getBlogPHID($object) I think?

171

For clarity, these are $phids, not $ids.

184

Or just setSubject($title).

185

Maybe just use the PHID? I think we've generally been doing that in the more recent stuff.

This revision is now accepted and ready to land.Nov 7 2015, 1:34 AM
chad updated this revision to Diff 34860.Nov 7 2015, 1:41 AM
chad marked 5 inline comments as done.
chad edited edge metadata.
  • per comments
Closed by commit rP6fe2377cc2c5: Add mail/feed support to PhamePost (authored by chad, committed by chad). · Explain WhyNov 7 2015, 1:43 AM
This revision was automatically updated to reflect the committed changes.
chad added a task: T9360: Unbeta Phame.Nov 7 2015, 1:44 AM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
18 lines
src/
2 lines
applications/
phame/
editor/
53 lines
mail/
21 lines
storage/
9 lines
48 lines

Diff 34853

View Options

resources/sql/autopatches/20151106.phame.post.mailkey.1.sql

Loading...
View Options

resources/sql/autopatches/20151106.phame.post.mailkey.2.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/mail/PhamePostReplyHandler.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phame/storage/PhamePostTransaction.php

Loading...
Phabricator · Built by Phacility