Ref T7964, HTML emails for Calendar event description changes should respect remarkup rules
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7964: Verify that calendar event update emails display correct hovertags.
- Commits
- Restricted Diffusion Commit
rP28b8c8e212d4: HTML emails for Calendar event description changes should respect remarkup rules
Create event and edit description, check that email has a correctly formatted remarkup description section.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendardescriptionemail
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8634 Build 9994: Run Core Tests Build 9993: arc lint + arc unit
Event Timeline
Comment Actions
Sorry, I think I led you astray a bit here.
I think the call to addRemarkupSection() in PhabricatorApplicationTransactionEditor also needs to be converted.
| src/applications/metamta/view/PhabricatorMetaMTAMailBody.php | ||
|---|---|---|
| 47–50 | I think we can actually toss this.. | |
| 52–53 | ...and do addPlaintextSection() here. As written, this isn't correct -- it adds HTML to the "plaintext" sections. | |
| 66 | ..and addHTMLSection(...) here. | |
| 68–69 | ...and addHTMLSection() here too. | |
| 120 | Then this can be left as-is.. | |
| 218 | And this can be removed. | |
| src/applications/metamta/view/PhabricatorMetaMTAMailBody.php | ||
|---|---|---|
| 52–53 | But it previously added "styled_text"? Seems counterintuitive to add plaintext by default in a remarkup section? | |
Comment Actions
This looks correct to me, except that I think the bold for headers got stripped out and never gets added now?
| src/applications/metamta/view/PhabricatorMetaMTAMailBody.php | ||
|---|---|---|
| 129 | It looks like we lost the bold here? | |
| src/applications/metamta/view/PhabricatorMetaMTAMailBody.php | ||
|---|---|---|
| 129 | Trying to recall why I removed the phutil_tag. I think this was intentional. What's the right way to make this bold without a phutil_tag? | |
Comment Actions
There's no way to make it bold without a phutil_tag().
My guess is that you might have removed it because the header is sometimes null, so it would have rendered an empty tag. Maybe something like this?
if ($header !== null) {
$header = phutil_tag(...);
}...but I'm not sure.